Skip to content

feat: add-shutdown-with-timeout-for-log-provider-and-processor #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 1, 2025
Merged

feat: add-shutdown-with-timeout-for-log-provider-and-processor #2941

merged 6 commits into from
May 1, 2025

Conversation

mohammadVatandoost
Copy link
Contributor

#2574 Part 4: Adding shutdown_with_timeout for log provider and processor

@mohammadVatandoost mohammadVatandoost requested a review from a team as a code owner April 22, 2025 20:26
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.3%. Comparing base (4f2de12) to head (cddc879).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...telemetry-sdk/src/logs/concurrent_log_processor.rs 0.0% 2 Missing ⚠️
opentelemetry-sdk/src/logs/batch_log_processor.rs 66.6% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2941     +/-   ##
=======================================
- Coverage   81.3%   81.3%   -0.1%     
=======================================
  Files        126     126             
  Lines      24294   24284     -10     
=======================================
- Hits       19774   19762     -12     
- Misses      4520    4522      +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cijothomas
cijothomas approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Lets also add a changelog entry and then we can merge

lalitb
lalitb approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to have changelog for Provider/Processor supporting shutdown with timeout.

@mohammadVatandoost
Copy link
Contributor Author

Looks good. Lets also add a changelog entry and then we can merge

Done

@mohammadVatandoost
Copy link
Contributor Author

LGTM. Good to have changelog for Provider/Processor supporting shutdown with timeout.

Done

@cijothomas cijothomas closed this May 1, 2025
@cijothomas cijothomas reopened this May 1, 2025
@cijothomas cijothomas merged commit 1d37e07 into open-telemetry:main May 1, 2025
43 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammadVatandoost @lalitb @cijothomas